Fix navigation keys on higher layers not working

[Seppel3210]

Some keyboard layouts have navigation keys in "unusual" positions on higher levels (e.g., Neo family layouts). These did not work at all, but this fixes them by not using key_without_modifiers() for Named(…) logical keys.

I also thought of implementing this by checking if key_without_modifiers() changes the std::mem::discriminant of the key (which would also be unexpected) and then you could return the logical key instead, but then you'd probably have to handle dead keys seperately, so I think doing this only for Named keys should be easier.

Fixes #2997.

[hecrj]

Thanks!

I think the proper fix is to use key without modifiers for key combinations (e.g. Ctrl+C) and the modified_key for single key bindings (e.g. motions).

Hope that works.

[coroa]

Even though this was merged navigation keys at least on Neo2 and Colemak are not working for instance in cosmic term: pop-os/cosmic-term#497 .

Can you describe what needs to be changed there?

Thank you

[edwloef]

I believe pop-os hasn't rebased their iced fork onto a commit that includes this patch yet.