Rehighlight TextEditor when Theme changes

[pml68]

It's far from perfect, but it's something. Maybe it's even acceptable.

[edwloef]

A better solution to this could be checking whether the theme has changed in the draw function, something like this: https://github.com/generic-daw/generic-daw/blob/d2d1c5f95733cd0169ffe03346491cfb959b9049/generic_daw_gui/src/widget/knob.rs#L205-L213

[pml68]

I tried doing something like that, but adding PartialEq as a trait requirement to the Theme generic caused issues with the Widget trait, but I'll try again today. Maybe I just didn't read the error carefully.

[pml68]

@edwloef I'm not sure what I did wrong last night, but it worked just fine this time around. Thanks for making me try again!

[pml68]

This solves #2817

[acidjazz]

Would be awesome if this got merged - really helpful 👍

[hecrj]

Thanks!

I have introduced a name method to theme::Base so we can just leverage that instead of adding a generic with PartialEq and Clone requirements.

Not as perfect, but it should be good enough for most use cases.