Skip to content

Remove the placeholder text when IME is activated in text input#2785

Merged
hecrj merged 1 commit intoiced-rs:masterfrom
rhysd:fix-placeholder-ime-pos
Feb 4, 2025
Merged

Remove the placeholder text when IME is activated in text input#2785
hecrj merged 1 commit intoiced-rs:masterfrom
rhysd:fix-placeholder-ime-pos

Conversation

@rhysd
Copy link
Contributor

@rhysd rhysd commented Feb 4, 2025 •
edited
Loading

This PR fixes that the placeholder text is not removed when IME is activated.

Problem

When the preedit window is opened, the placeholder text is not removed. This is weird because the text input is already editing the content but the placeholder text is still there.

before.mp4

Solution

This PR removes the placeholder text when the input method is activated even if the text input content is not committed. This is the same behavior as <input> element of web browsers.

after.mp4

@rhysd rhysd force-pushed the fix-placeholder-ime-pos branch from 23ed2b6 to e4ff212 Compare February 4, 2025 15:47
@rhysd rhysd changed the title Fix position of preedit doesn't consider placeholder in TextInput Remove the placeholder text when IME is activated in text input Feb 4, 2025
@rhysd rhysd force-pushed the fix-placeholder-ime-pos branch from e4ff212 to eedaa37 Compare February 4, 2025 15:53
@hecrj hecrj added this to the 0.14 milestone Feb 4, 2025
hecrj
hecrj approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hecrj hecrj merged commit 1f9723a into iced-rs:master Feb 4, 2025
15 checks passed
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Feb 11, 2025
@kenz-gelsoft
Remove the placeholder text when IME is activated in text input
cf5ed2c 
- backport iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Feb 11, 2025
@kenz-gelsoft
Fix the preedit text placement on scrolled content
bbc6414 
- backports iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Feb 11, 2025
@kenz-gelsoft
Set correct text size for preedit window
02370b3 
- backports iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Apr 27, 2025
@kenz-gelsoft
Remove the placeholder text when IME is activated in text input
e6e063e 
- backport iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Apr 27, 2025
@kenz-gelsoft
Fix the preedit text placement on scrolled content
e1fa0d5 
- backports iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Apr 27, 2025
@kenz-gelsoft
Set correct text size for preedit window
670bf30 
- backports iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 10, 2025
@kenz-gelsoft
Remove the placeholder text when IME is activated in text input
cf465bd 
- backport iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 10, 2025
@kenz-gelsoft
Fix the preedit text placement on scrolled content
534e305 
- backports iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 10, 2025
@kenz-gelsoft
Set correct text size for preedit window
baedc6c 
- backports iced-rs#2785
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 10, 2025
@kenz-gelsoft @rhysd
Remove the placeholder text when IME is activated in text input
0db3fff 
- backport iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 10, 2025
@kenz-gelsoft @rhysd
Fix the preedit text placement on scrolled content
26a68f0 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 10, 2025
@kenz-gelsoft @rhysd
Set correct text size for preedit window
9274b0c 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 28, 2025
@kenz-gelsoft @rhysd
Remove the placeholder text when IME is activated in text input
d9d92ea 
- backport iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 28, 2025
@kenz-gelsoft @rhysd
Fix the preedit text placement on scrolled content
c584fb2 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request May 28, 2025
@kenz-gelsoft @rhysd
Set correct text size for preedit window
fd715f6 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Jun 22, 2025
@kenz-gelsoft @rhysd
Remove the placeholder text when IME is activated in text input
8002f01 
- backport iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Jun 22, 2025
@kenz-gelsoft @rhysd
Fix the preedit text placement on scrolled content
3be2fe8 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Jun 22, 2025
@kenz-gelsoft @rhysd
Set correct text size for preedit window
f3fb7e0 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Nov 2, 2025
@kenz-gelsoft @rhysd
Remove the placeholder text when IME is activated in text input
620eb27 
- backport iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Nov 2, 2025
@kenz-gelsoft @rhysd
Fix the preedit text placement on scrolled content
35836df 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Nov 2, 2025
@kenz-gelsoft @rhysd
Set correct text size for preedit window
a84f94d 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Remove the placeholder text when IME is activated in text input
ca03041 
- backport iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Fix the preedit text placement on scrolled content
646e64f 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Set correct text size for preedit window
f9852ad 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Remove the placeholder text when IME is activated in text input
cc0cd84 
- backport iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Fix the preedit text placement on scrolled content
fbfdd46 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Set correct text size for preedit window
126e89e 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Remove the placeholder text when IME is activated in text input
4761603 
- backport iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Fix the preedit text placement on scrolled content
eb081ea 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
kenz-gelsoft added a commit to kenz-gelsoft/iced that referenced this pull request Dec 8, 2025
@kenz-gelsoft @rhysd
Set correct text size for preedit window
2ad5fdd 
- backports iced-rs#2785

Co-authored-by: rhysd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hecrj hecrj hecrj approved these changes

Assignees

No one assigned

Labels

accessibility bug Something isn't working fix text widget

Projects

None yet

Milestone

0.14

Development

Successfully merging this pull request may close these issues.

2 participants

@rhysd @hecrj