Merged
Conversation
hecrj
force-pushed
the
get-monitor-size
branch
from
3aa8851 to
d7d8b67
Compare
hecrj
changed the title
iced::window::get_monitor_size to get the logical size of the current monitorwindow::monitor_size task
hecrj
approved these changes
Nov 20, 2025
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
I made the monitor logical dimensions depend on the scale factor of the window for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
iced::window::get_monitor_sizefunction to create a task to get the logical size of current monitor.This function is useful to determine the size of window when resizing it. In my case, I want to resize a window to fit to its content. When the content is big, the window can overflow off the monitor. By calculating the window size based on the monitor size, I can prevent the overflow.