Upgrade dark-light to v2#2724
Merged
hecrj merged 4 commits intoiced-rs:masterfrom Jan 14, 2025
Rudxain:dl2
Merged
Conversation
Contributor
|
|
T-256
reviewed
Jan 10, 2025
core/src/theme.rs
Outdated
Comment on lines
+173
to
+174
| Ok(dark_light::Mode::Light) | Ok(dark_light::Mode::Unspecified) | Err(_) => { | ||
| Theme::Light |
Contributor
There was a problem hiding this comment.
Suggested change
| Ok(dark_light::Mode::Light) | Ok(dark_light::Mode::Unspecified) | Err(_) => { | |
| Theme::Light | |
| _ => Theme::Light, |
Contributor
Author
There was a problem hiding this comment.
Personally I would've made this change before even opening the PR, but I decided to preserve the verbosity of the original just-in-case there's a reason for the verbosity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo checked, as the repo is too big togit clone(for me). I know I could download without thegit logdata, but I don't have much time now.