Merged
Conversation
hecrj
approved these changes
Jan 14, 2025
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Lots of new dependencies, hope they are worth it!
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dependency
imageto 0.25.5, it has been out for a while - https://github.com/image-rs/image/tagsSince iced does not re-export image (from what I can see?) I need to maintain version parity, it looks like the examples can inherit from the workspace - but other apps have to manually maintain this parity. Since I was already dependent on image, I could either downgrade my version or upgrade yours :)
I tested the following examples and they all still seem to work fine: