Add text_shaping method to combo_box widget#2714
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Nov 20, 2025
Merged
Conversation
hecrj
force-pushed
the
combobox-text-shaping
branch
from
f86397b to
045ffa8
Compare
hecrj
changed the title
text_shaping method to combo_box widget
hecrj
approved these changes
Nov 19, 2025
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
Although this shouldn't be as necessary since iced auto-selects the best shaping strategy by default now.
hecrj
force-pushed
the
combobox-text-shaping
branch
from
045ffa8 to
d5e0240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, unlike PickList, ComboBox didn't have a setter for text_shaping so I added it and adapted the combo_box example with languages that would use Advanced text shaping.