Add .id method to text_editor to make it focusable programmatically#2653
Add .id method to text_editor to make it focusable programmatically#2653hecrj merged 2 commits intoiced-rs:masterfrom
.id method to text_editor to make it focusable programmatically#2653Conversation
496cb88 to
14e8ba5
Compare
|
This seems to be contributing to existing unnecessary code duplication. I'm exploring some cleanup in #2745 . |
|
Just merge this already. We need to be able to focus a text editor. |
|
@hecrj |
Why can't you just copy and paste the text editor into your own app and implement this yourself if you're in a hurry to use this solution? |
|
@airstrike I tried to copy the text_editor.rs into the project and it depends on some private modules, I don't want to end up to copy too many files to my project. |
|
Is there any problem with merging this? |
|
I don't think there is much gained by commenting on this PR. Unless you have something to add please just put a 👍 on the top comment, I don't think more comments will help, let's not spam maintainers. |
ea8c1e5 to
5a21f0e
Compare
.id method and text_editor::focus task.id method to text_editor to make it focusable programmatically
5a21f0e to
d0df7c6
Compare
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
About time we merge this.
This functionality adds the ability to programmatically focus a
text_editorwidget.text_inputwidget.