Fixed bug where delete key wasn't working in the text editor#2632
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Oct 14, 2024
leo030303:fix_delete_key_bug
Merged
Fixed bug where delete key wasn't working in the text editor#2632hecrj merged 1 commit intoiced-rs:masterfrom leo030303:fix_delete_key_bug
hecrj merged 1 commit intoiced-rs:masterfrom
leo030303:fix_delete_key_bug
Conversation
hecrj
approved these changes
Oct 14, 2024
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
Your fix would have broken the delete key in the numpad. The proper fix is to actually match on the DELETE UTF-8 character code instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2631.
When the delete key was pressed, it would only run the Delete binding if the content of the text editor was None. This was the source of the bug, I switched it to an is_some() check.