Include images and saved meshes when pasting Frame#2605
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Sep 24, 2024
Merged
Conversation
`tiny_skia::Frame` was ignoring images in `Frame::paste`, making images not show up when created in a `with_clip` context. `wgpu::Frame` similarly did not pass through meshes in its paste method, that may have been saved from a nested `with_clip` call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tiny_skia::Framewas ignoring images inFrame::paste, making images not show up when created in awith_clipcontext.wgpu::Framesimilarly did not pass through meshes in its paste method, that may have been saved from a nestedwith_clipcall.I'm not sure that nesting
with_clipmakes a lot of sense, because only the innermost clip region gets applied (should this be documented?), also it seems like images are not yet affected by clipping? Nevertheless, these fixes seem relevant.