fix: Remove --cleanup-tag and --verify-tag to prevent workflow failure #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the workflow error: "tag doesn't exist in the repo, aborting due to --verify-tag flag" The issue occurred because: 1. "Create and push tag" step creates and pushes the tag 2. "Create GitHub Release" step deletes the release with --cleanup-tag (which also deletes the tag we just created!) 3. Then tries to create release with --verify-tag for a non-existent tag Changes: - Removed --cleanup-tag from gh release delete (tag deletion is handled in the "Create and push tag" step) - Removed --verify-tag from gh release create (not needed since we just created and pushed the tag) Now the workflow correctly: 1. Deletes old tag if exists 2. Creates and pushes new tag 3. Deletes old release (without touching the tag) 4. Creates new release using the freshly pushed tag ✅ This fix is required for the "none" version bump option to work properly when republishing existing versions like v3.3.0.
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the workflow error: "tag doesn't exist in the repo, aborting due to --verify-tag flag"
The issue occurred because:
Changes:
Now the workflow correctly:
This fix is required for the "none" version bump option to work properly when republishing existing versions like v3.3.0.