fix: react JSX runtime module not found error #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tsconfig.json to use the new JSX transform (react-jsx) instead of the legacy transform (react). This aligns TypeScript's compilation with Vite's @vitejs/plugin-react which uses the new JSX transform by default. This fixes the module resolution issue where the build output correctly imports from 'react/jsx-runtime' (marked as external in vite.config.ts) but TypeScript was configured for the old transform. Changes: - tsconfig.json: Changed "jsx": "react" to "jsx": "react-jsx" Benefits: - Eliminates JSX transform mismatch between TypeScript and Vite - Aligns with React 17+ best practices - Maintains backward compatibility (source still imports React) - All 51 tests passing ✅
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tsconfig.json to use the new JSX transform (react-jsx) instead of the legacy transform (react). This aligns TypeScript's compilation with Vite's @vitejs/plugin-react which uses the new JSX transform by default.
This fixes the module resolution issue where the build output correctly imports from 'react/jsx-runtime' (marked as external in vite.config.ts) but TypeScript was configured for the old transform.
Changes:
Benefits: