fix: demo display issue #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Demo was importing from "react-lite-youtube-embed" (v2.6.0 from npm) - This old version doesn't have the event timing fix from PR #203 - CHECKPOINT 2 wasn't showing because onReady events weren't firing Solution: - Changed import to "@ibrahimcesar/react-lite-youtube-embed" - This uses the local source code (file:..) with all latest fixes - Rebuilt package and reinstalled demo dependencies Impact: - Demo now uses latest event handling code - CHECKPOINT 2 (Player Ready) should now appear consistently - All event handlers will work properly Fixes: CHECKPOINT 2 visibility issue reported by user
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Impact:
Fixes: CHECKPOINT 2 visibility issue reported by user