fix: player state not updating on play #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The player state events (onPlay, onPause, onStateChange, etc.) were not firing reliably in the demo because the "listening" postMessage was sent before the YouTube iframe API was fully initialized. Changes: - Add retry logic with exponential backoff delays (0, 100, 250, 500, 1000ms) - YouTube iframe initialization time varies by network/browser conditions - Multiple retry attempts ensure the listening message is received - Fix TypeScript type for setTimeout (use ReturnType instead of NodeJS.Timeout) This resolves the issue where the Player State display would stay stuck on "Not Started" even after playing the video. Impact: - Fixes event tracking in the demo's Interactive Events section - Improves reliability for all event handlers (onReady, onPlay, etc.) - No breaking changes - fully backward compatible - All 51 tests passing
Contributor
size-limit report 📦
|
ibrahimcesar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The player state events (onPlay, onPause, onStateChange, etc.) were not firing reliably in the demo because the "listening" postMessage was sent before the YouTube iframe API was fully initialized.
Changes:
This resolves the issue where the Player State display would stay stuck on "Not Started" even after playing the video.
Impact: