fix: update demo deployment to use local library build #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deployment workflow was failing because it tried to install [email protected] from npmjs.org, but: - The package is scoped as @ibrahimcesar/react-lite-youtube-embed - It's published to GitHub Packages, not npmjs.org - Version 3.0.5 may not be published yet Solution: - Build the library from source first - Use local build for demo (npm install ../. - This ensures demo always uses latest repository code - No dependency on published packages Benefits: - Demo always shows current code - Works regardless of publish status - Better CI/CD efficiency with shared caching
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment workflow was failing because it tried to install [email protected] from npmjs.org, but:
Solution:
Benefits: