Claude/fix issue 148 conflict 01 r7e z et4 t1j ksqr xjo trj er #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses several critical issues found during code review: 1. Fixed missing useEffect dependencies: - Added onIframeAdded to useEffect deps in index.tsx - Wrapped onIframeAdded in useCallback to prevent unnecessary re-renders - Added vi, format, imageRes deps to useEffect in useYoutubeThumbnail.tsx 2. Fixed conflicting cookie logic: - Removed redundant noCookie prop assignment that was being overwritten - Simplified to use only cookie prop for determining YouTube domain - Added @deprecated JSDoc annotation to noCookie prop 3. Replaced deprecated frameBorder attribute: - Removed frameBorder="0" from iframe element - Added style={{ border: 0 }} to comply with React standards All tests passing (20/20).
Resolved conflicts between accessibility improvements (focusOnLoad) and
critical bug fixes (hook dependencies). The resolution preserves both:
- Props params parsing logic for custom YouTube parameters
- Complete useEffect dependency array including focusOnLoad and ref
- All memoization optimizations from both branches
Changes merged from claude/fix-critical-bugs branch:
- Fixed useEffect dependencies in useYoutubeThumbnail hook
- Wrapped onIframeAdded in useCallback with proper dependencies
- Replaced deprecated frameBorder with style={{ border: 0 }}
All 20 tests passing ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.