Skip to content

Conversation

@rlueder
Copy link
Contributor

@rlueder rlueder commented Aug 19, 2025

This PR fixes an issue introduced on this PR where props.params are not being passed to the iframe src parameter:

<LiteYouTubeEmbed params="start=1160&foo=bar" />

BEFORE FIX:

<iframe src="https://www.youtube-nocookie.com/embed/L2vS_050c-M?"></iframe> // <-- notice no params are passed to src

AFTER FIX:

<iframe src="https://www.youtube-nocookie.com/embed/L2vS_050c-M?start=1160&amp;foo=bar"></iframe> // <-- props.params are correctly passed to src

@rlueder
Copy link
Contributor Author

rlueder commented Aug 20, 2025

@ibrahimcesar just a nudge I reopened the PR with the fix for props.params Thanks!

@ibrahimcesar ibrahimcesar merged commit 9dc7946 into ibrahimcesar:main Aug 20, 2025
1 check passed
@rlueder rlueder deleted the fix-props branch August 20, 2025 14:02
@ibrahimcesar
Copy link
Owner

ibrahimcesar commented Aug 20, 2025

Published @ https://github.com/ibrahimcesar/react-lite-youtube-embed/releases/tag/v2.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants