resolve build failures of node-java in Node v14 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates package.json to get a node-java version that resolves the subject issue in new branch node14-zos: https://github.com/ibmruntimes/node-java.git It also removes the requirement of setting LDFLAGS env var prior to building node-java or node-jdbc. Ref: ibmruntimes/node-java#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This PR updates package.json to get a node-java version that resolves the subject issue in new branch node14-zos:
https://github.com/ibmruntimes/node-java.git
It also removes the requirement of setting LDFLAGS env var prior to building node-java or node-jdbc.
Ref node-java PR: ibmruntimes/node-java#1
This node-jdbc from branch
zosworks with both Node v12 and v14.For users of Node v8, branch
node8-zosshould be used, as explained in the above PR.