Skip to content

Conversation

@cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 6, 2022

Python 3.7 support is broken in datafusion. See datafusion-contrib/datafusion-python#8.

Basic things are working, we need to add more operations (depending on the datafusion support) and
additional backend specific tests.

resolves ibis-project#2627
@cpcloud cpcloud added datafusion The Apache DataFusion backend ci Continuous Integration issues or PRs labels Jan 6, 2022
@cpcloud cpcloud requested review from jreback and kszucs January 6, 2022 00:18
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

prob should drop 3.7 in next major release as well

@ibis-squawk-bot
Copy link
Contributor

/condalock

@cpcloud cpcloud enabled auto-merge (rebase) January 6, 2022 00:56
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2022

Unit Test Results

         8 files           8 suites   16m 54s ⏱️
  2 875 tests   2 805 ✔️   70 💤 0
23 000 runs  22 440 ✔️ 560 💤 0

Results for commit 7dcfb0e.

♻️ This comment has been updated with latest results.

@cpcloud cpcloud disabled auto-merge January 6, 2022 02:43
@cpcloud cpcloud merged commit 7dcfb0e into ibis-project:master Jan 6, 2022
@cpcloud cpcloud deleted the datafusion-fixes branch January 11, 2022 13:43
@ibis-project-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration issues or PRs datafusion The Apache DataFusion backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants