Skip to content

fix(sqlite): precision loss in divide #11759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −0
Open

fix(sqlite): precision loss in divide #11759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ibis/backends/sql/compilers/sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,5 +545,13 @@ def visit_DateDelta(self, op, *, left, right, part):
)
return self.f._ibis_date_delta(left, right)

def visit_Divide(self, op, *, left, right):
left = (
sge.cast(left, sge.DataType.Type.FLOAT, copy=False)
if all(arg.dtype.is_integer() for arg in op.args)
else left
)
return self.binop(sge.Div, left, right)


compiler = SQLiteCompiler()
22 changes: 22 additions & 0 deletions ibis/backends/sqlite/tests/test_numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from __future__ import annotations

import pandas as pd
import pandas.testing as tm

import ibis


def test_divide_precision(con):
df = pd.DataFrame({"a": [10, 20, 30], "b": [2, 3, 4], "c": [5, 10, 15]})

t = ibis.memtable(df)

expr = (t.a + t.b) * t.c - t.a / t.b

actual = con.execute(expr).squeeze()

expected = pd.Series([55.0, 223.333, 502.5])

tm.assert_series_equal(
actual, expected, check_exact=False, check_names=False, atol=0.001
)
Loading