fix(saveEntity, saveTripsForCalendar): Resolve missing defaults with GTFS spec changes #720
Conversation
philip-cline
requested review from
binh-dam-ibigroup and
miles-grant-ibigroup
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Getting in the right direction. The remaining gap is to initialize the feed email and URL fields in UI. See also other comments.
| import {saveTripPattern} from './tripPattern' | ||
| import {newGtfsEntity, fetchBaseGtfs} from './editor' | ||
|
|
There was a problem hiding this comment.
Can these imports be before the import type or is this something prettier automatically format?
There was a problem hiding this comment.
This was an automatic format
| defaults.feed_contact_url = '' | ||
| defaults.feed_contact_email = '' |
There was a problem hiding this comment.
These fields make it to the database, but on page reload are not populated in the UI. Can you fix this?
There was a problem hiding this comment.
This was a problem with the fetchBaseGTFS method, which did not fetch the new fields. Fixed in c48bb18
lib/editor/actions/trip.js
Outdated
| trips = trips.map(snakeCaseKeys) | ||
| return Promise.all(trips.filter(t => t).map((trip, index) => { | ||
| const tripExists = !entityIsNew(trip) && trip.id !== null | ||
| const tripCopy: any = (trip: any) |
There was a problem hiding this comment.
I would clone it (otherwise you are improperly overwrite data).
| return Promise.all(trips.filter(t => t).map((trip, index) => { | ||
| const tripExists = !entityIsNew(trip) && trip.id !== null | ||
| const tripCopy: any = (trip: any) | ||
| // Add default value to continuous pickup if not provided |
There was a problem hiding this comment.
Add comment saying editing continuous pickup/drop off is not currently supported in the schedule editor.
…fields, address comments
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
LGTM, thank you for working on this.
|
Passing this on to @miles-grant-ibigroup for review |
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Great patch! Well done finding that error.
Closes #716, #717. New fields added with the changes to the GTFS spec (#668) are missing from old feeds when a GTFS entity is saved, producing a
field missing from JSON objecterror. Fixed by providing default values which are overridden if the feed provides its own values for the new fields.Checklist
devbefore they can be merged tomaster)