Skip to content

Conversation

@landonreed
Copy link
Contributor

@robertgregg3, here are some changes for #668 that I think will clean things up a bit. I've just added a method to encapsulate the EditorValidationIssue return value, which gets reused quite a bit in this method.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #690 (5d17fbb) into gtfs-spec-changes (7717c28) will increase coverage by 0.01%.
The diff coverage is 30.76%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           gtfs-spec-changes     #690      +/-   ##
=====================================================
+ Coverage              15.67%   15.68%   +0.01%     
=====================================================
  Files                    329      329              
  Lines                  16820    16822       +2     
  Branches                5069     5070       +1     
=====================================================
+ Hits                    2636     2638       +2     
  Misses                 12133    12133              
  Partials                2051     2051              
Flag Coverage Δ
unit_tests 15.68% <30.76%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/editor/util/validation.js 44.44% <30.76%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7717c28...5d17fbb. Read the comment docs.

@robertgregg3 robertgregg3 merged commit c728b3d into gtfs-spec-changes Jul 2, 2021
@landonreed landonreed deleted the gtfs-spec-changes-ltr branch July 6, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants