Added missing GTFS Extended Route Types #656
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -300,6 +300,8 @@ export default class EditorInput extends Component<Props> { | |
| </span> | ||
| ) | ||
| case 'DROPDOWN': | ||
| const standard = 'Standard' | ||
| const extended = 'Extended' | ||
| return ( | ||
|
Contributor
There was a problem hiding this comment. To fix the flow type issues and simplify things, I would add something like the following: if (!field.options) {
console.warn(`Field `field.name` does not have options configured, but is marked as inputType=DROPDOWN`)
return null
}Then, you should be able to remove the
Author
There was a problem hiding this comment. Where do you see the flow issues? When I load the project (before typing any code, I get these kind of squigglies from the beginning of the render method:
Author
There was a problem hiding this comment. When I run
Contributor
There was a problem hiding this comment. The flow errors are showing up in the GitHub builds: https://github.com/ibi-group/datatools-ui/pull/656/checks?check_run_id=2298915284 Locally, you should run |
||
| <FormGroup | ||
| {...formProps} | ||
|
|
@@ -314,7 +316,18 @@ export default class EditorInput extends Component<Props> { | |
| ? <option disabled value=''>{field.required ? '-- select an option --' : '(optional)' }</option> | ||
| : null | ||
| } | ||
| {field.name === 'route_type' && | ||
| <optgroup label={standard}> | ||
| {field.options.slice(0, 7).map(o => ( | ||
|
||
| <option value={o.value} key={o.value}>{o.text} ({o.value})</option>))} | ||
| </optgroup>} | ||
| {field.name === 'route_type' && | ||
| <optgroup label={extended}> | ||
| {field.options.slice(8).map(o => ( | ||
| <option value={o.value} key={o.value}>{o.text} ({o.value})</option>))} | ||
| </optgroup>} | ||
| )} | ||
binh-dam-ibigroup marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| {field.name !== 'route_type' && field.options && field.options.map(o => (<option value={o.value} key={o.value}>{o.text || o.value}</option>))}} | ||
| </FormControl> | ||
| </FormGroup> | ||
| ) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add options 11 and 12 (they were recently added to the standard set)? See the spec for
routes.txt: https://developers.google.com/transit/gtfs/reference#routestxt for more infoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!