Return summarized project info on collection get api routes #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #319 +/- ##
============================================
+ Coverage 19.91% 19.93% +0.01%
Complexity 410 410
============================================
Files 151 151
Lines 8331 8334 +3
Branches 1157 1157
============================================
+ Hits 1659 1661 +2
- Misses 6523 6524 +1
Partials 149 149
Continue to review full report at Codecov.
|
5 tasks
Contributor
|
This fix is related to changes to DeploymentController in #310. (Just adding a ref) |
landonreed
reviewed
Jun 9, 2020
|
|
||
| /** | ||
| * A MixIn to be applied to this deployment, for returning a single deployment, so that the list of ec2Instances is | ||
| * included in the JSON response. |
Contributor
There was a problem hiding this comment.
Warning: javadoc copy pasta
landonreed
approved these changes
Jun 9, 2020
Contributor
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
Looks good, thanks. javadoc just needs an update.
binh-dam-ibigroup
approved these changes
Jun 10, 2020
Contributor
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Requests for a list of projects were becoming painfully slow on my local instance. It turns out that not returning the
otpServersin each project when returning a list of projects dramatically speeds things up.