-
Notifications
You must be signed in to change notification settings - Fork 82
raml2html: Upgrade to PHP 7.4 #1898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adriendupuis
merged 4 commits into
stabilize-html-render
from
stabilize-html-render-7.4
Feb 16, 2023
Merged
raml2html: Upgrade to PHP 7.4 #1898
adriendupuis
merged 4 commits into
stabilize-html-render
from
stabilize-html-render-7.4
Feb 16, 2023
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Patch to fix "PHP Notice: Trying to access array offset on value of type null in /Users/adriendupuis/www/developer-documentation/tools/raml2html/vendor/raml-org/raml-php-parser/src/Body.php on line 231" appearing with PHP 7.4
PHP 7.4 is the minimum requirement for commonmark package:
Problem 1
- Root composer.json requires league/commonmark ^2.3 -> satisfiable by league/commonmark[2.3.0, ..., 2.3.9].
- league/commonmark[2.3.0, ..., 2.3.9] require php ^7.4 || ^8.0 -> your php version (7.2.34) does not satisfy that requirement.
2516af3 to
c748feb
Compare
alongosz
reviewed
Feb 16, 2023
b79a57b to
98e7de2
Compare
alongosz
approved these changes
Feb 16, 2023
adriendupuis
pushed a commit
that referenced
this pull request
Feb 16, 2023
* Stabilized render of REST HTML * raml2html: Upgrade to PHP 7.4 (#1898)
adriendupuis
pushed a commit
that referenced
this pull request
Feb 16, 2023
* Stabilized render of REST HTML * raml2html: Upgrade to PHP 7.4 (#1898)
adriendupuis
pushed a commit
that referenced
this pull request
Feb 16, 2023
adriendupuis
pushed a commit
that referenced
this pull request
Feb 16, 2023
adriendupuis
pushed a commit
that referenced
this pull request
Feb 16, 2023
* Stabilized render of REST HTML * raml2html: Upgrade to PHP 7.4 (#1898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade from PHP 7.2 to PHP 7.4
Fix
Body::getExample()usage to avoidPHP Notice: Trying to access array offset on value of type null in tools/raml2html/vendor/raml-org/raml-php-parser/src/Body.php on line 231appearing with PHP 7.4PHP 7.4 is the minimum requirement for commonmark package: