-
Notifications
You must be signed in to change notification settings - Fork 17
IBX-10494: Refactored location filtering logic #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f616985 to
8df9df8
Compare
...sistence/Legacy/Filter/SortClauseQueryBuilder/Content/DateModifiedSortClauseQueryBuilder.php
Show resolved
Hide resolved
konradoboza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but please evaluate @alongosz remark. I guess we don't have other way to distinguish queries apart from location alias? The current one looks a bit hacky but can go as-is I guess.
tests/integration/Core/Repository/Filtering/ContentFilteringTest.php
Outdated
Show resolved
Hide resolved
...istence/Legacy/Filter/SortClauseQueryBuilder/Location/BaseLocationSortClauseQueryBuilder.php
Show resolved
Hide resolved
...istence/Legacy/Filter/SortClauseQueryBuilder/Location/BaseLocationSortClauseQueryBuilder.php
Outdated
Show resolved
Hide resolved
…mprove folder creation logic
|
|
Merged in #655 |



Description:
getContentInfo()->getMainLocationId()everywhere.For QA:
Documentation: