Updated API for requesting subtitles from bilibili#1285
Merged
iawia002 merged 1 commit intoiawia002:masterfrom Oct 16, 2023
Merged
Updated API for requesting subtitles from bilibili#1285iawia002 merged 1 commit intoiawia002:masterfrom
iawia002 merged 1 commit intoiawia002:masterfrom
Conversation
iawia002
reviewed
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous API URL still works, but it now only returns an empty
subtitle_url, makingluxunable to download subtitles anymore. The JSON file returned by the new API URL has changed a bit, but not much as far as subtitles are concerned, and thebilibiliWebInterfacestruct is only used once on the following line, so I don't think there will be unexpected side effects.lux/extractors/bilibili/bilibili.go
Line 508 in 90109ff