Skip to content

ES6 style #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jimmywarting wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ES6 style #61

jimmywarting wants to merge 4 commits into from

Conversation

@jimmywarting
Copy link

@jimmywarting jimmywarting commented Oct 18, 2021

I thought i would not let my pr go to waste... you said you where fine with const/let and everything else but ESM.

  • jsdoc for better type support
  • const/let requires node 6+. So added a engine field to package.json with minimum support
  • also switched padRight/Left to padEnd/padStart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@windusayles windusayles windusayles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmywarting @windusayles