-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Update Jenkinsfile #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Jenkinsfile #500
Conversation
WalkthroughThe Jenkins pipeline configuration was updated to use newer Docker images for the build agents. The back-end stage now utilizes Maven with AdoptOpenJDK 17, and the front-end stage uses Node.js version 17 Alpine. No changes were made to the pipeline steps or public interfaces. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
multi-stage-multi-agent/Jenkinsfile (2)
6-7: Verify image existence & consider switching to Eclipse Temurin tags
maven:3.8.1-adoptopenjdk-17may have been deprecated after the AdoptOpenJDK→Eclipse Temurin migration. If the image has vanished your build will fail at pull time.
Action items:
- Run
docker pull maven:3.8.1-adoptopenjdk-17locally or in CI to confirm it still resolves.- If it 404s, bump to an actively-maintained tag, e.g.:
- docker { image 'maven:3.8.1-adoptopenjdk-17' } + docker { image 'maven:3.9.6-eclipse-temurin-17' }(or pin whatever Maven/JDK combo your project requires).
14-15: Node 17 is not LTS – prefer an LTS image unless you need 17-specific featuresNode 17 went EOL in mid-2022. Using a non-LTS runtime in CI can break reproducible builds when upstream security patches stop. Unless the application explicitly targets v17, consider upgrading to the current LTS (18 or 20):
- docker { image 'node:17-alpine' } + docker { image 'node:20-alpine' } // or 18-alpine for parity with prod
Summary by CodeRabbit