Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Submodule initialization inherits Git's 30-second total deadline. Slow clones are interrupted mid-checkout, but worktree creation still succeeds. The reported Windows 0.1.5 trace confirms a timeout after 30.9 seconds.
Change
Set
timeoutMs: nullonly for the submodule update, matching the existing cancellablegit worktree addpath. Cancellation and best-effort failure handling remain unchanged; the warning now describes submodules as potentially incomplete.Scope and approval
Follows #26409 to fix the 30-second submodule-update timeout reported in #26390. #7674 introduced automatic initialization; #23802 later removed the worktree-add deadline. This applies the same policy to submodule checkout.
Verification
vp run check:changed: all static checks pass; 172 tests pass, one skipped, ten failures. All ten also reproduce with the original fork code at6575ce3250on this Windows/Git 2.32 host.6575ce3250)6f8633f5de)sub03/nestedhas no files despite clean parent statusModel and harness: GPT-6.1 Sol via Codex in T3 Code.