Skip to content

Conversation

@SaemJeon
Copy link
Contributor

@SaemJeon SaemJeon commented Apr 13, 2021

Update Mocha & nyc version
mocha: 5.2.0 -> 8.3.2
@types/mocha: 5.2.5 -> 8.2.2
nyc: 14.0.0 -> 15.1.

@SaemJeon SaemJeon force-pushed the update-mocha-version branch from 34b5f6d to 156e0d3 Compare April 20, 2021 21:25
@wgoehrig wgoehrig marked this pull request as ready for review April 20, 2021 21:30
@wgoehrig
Copy link
Member

@grigasp the presentation coverage requirements are failing after updating nyc - can you take a look at those?

@grigasp
Copy link
Member

grigasp commented Apr 21, 2021

@grigasp the presentation coverage requirements are failing after updating nyc - can you take a look at those?

done

@calebmshafer
Copy link
Member

@SaemJeon can you do the merge required here? I'll override the massive number of reviewers here to get it merged.

@SaemJeon
Copy link
Contributor Author

SaemJeon commented May 5, 2021

@calebmshafer I think I did it. Please let me know if I didn't do it correctly.

Copy link
Member

@calebmshafer calebmshafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If Grigas approves of the presentation changes, I'll override the rest of the reviewers tomorrow.

@calebmshafer
Copy link
Member

@SaemJeon can you take a look at the failure in the integration tests? https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=877365&view=logs&j=11a1ff10-dba1-50ce-27e2-db260e9900bf&t=575d2bbe-c3a7-5f15-a080-f6c1d4bf0611

It looks like there is some issue with using this.skip in the Rpc Interface tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants