-
Notifications
You must be signed in to change notification settings - Fork 231
Update mocha & nyc version #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…date-mocha-version
34b5f6d to
156e0d3
Compare
|
@grigasp the presentation coverage requirements are failing after updating nyc - can you take a look at those? |
done |
|
@SaemJeon can you do the merge required here? I'll override the massive number of reviewers here to get it merged. |
|
@calebmshafer I think I did it. Please let me know if I didn't do it correctly. |
calebmshafer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If Grigas approves of the presentation changes, I'll override the rest of the reviewers tomorrow.
|
@SaemJeon can you take a look at the failure in the integration tests? https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=877365&view=logs&j=11a1ff10-dba1-50ce-27e2-db260e9900bf&t=575d2bbe-c3a7-5f15-a080-f6c1d4bf0611 It looks like there is some issue with using |
Update Mocha & nyc version
mocha: 5.2.0 -> 8.3.2
@types/mocha: 5.2.5 -> 8.2.2
nyc: 14.0.0 -> 15.1.