Skip to content

Commit 1f679de

Browse files
committed
fix(pointcloud): remove unused variable
This commit fixes a left-over from #719
1 parent 19ae01c commit 1f679de

4 files changed

Lines changed: 8 additions & 14 deletions

File tree

examples/pointcloud.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ function showPointcloud(serverUrl, fileName, lopocsTable) {
7777
var info = document.getElementById('info');
7878
oldPostUpdate.apply(pointcloud, arguments);
7979
info.textContent = 'Nb points: ' +
80-
pointcloud.counters.displayedCount.toLocaleString() + ' (' +
81-
Math.floor(100 * pointcloud.counters.displayedCount / pointcloud.counters.pointCount) + '%) (' +
82-
view.mainLoop.gfxEngine.renderer.info.memory.geometries + ')';
80+
pointcloud.displayedCount.toLocaleString();
8381
};
8482
window.view = view;
8583
}

examples/pointcloud_globe.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,7 @@ function showPointcloud(serverUrl, fileName) {
5050
var info = document.getElementById('info');
5151
oldPostUpdate.apply(pointcloud, arguments);
5252
info.textContent = 'Nb points: ' +
53-
pointcloud.counters.displayedCount.toLocaleString() + ' (' +
54-
Math.floor(100 * pointcloud.counters.displayedCount / pointcloud.counters.pointCount) + '%) (' +
55-
view.mainLoop.gfxEngine.renderer.info.memory.geometries + ')';
53+
pointcloud.displayedCount.toLocaleString();
5654
};
5755
window.view = view;
5856
}

src/Process/PointCloudProcessing.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -291,22 +291,20 @@ export default {
291291
return;
292292
}
293293

294-
layer.counters = {
295-
displayedCount: 0,
296-
};
294+
layer.displayedCount = 0;
297295
for (const pts of layer.group.children) {
298-
layer.counters.displayedCount += pts.geometry.drawRange.count;
296+
layer.displayedCount += pts.geometry.drawRange.count;
299297
}
300298

301-
if (layer.counters.displayedCount > layer.pointBudget) {
302-
const reduction = layer.pointBudget / layer.counters.displayedCount;
299+
if (layer.displayedCount > layer.pointBudget) {
300+
const reduction = layer.pointBudget / layer.displayedCount;
303301
for (const pts of layer.group.children) {
304302
if (pts.material.visible) {
305303
const count = Math.max(1.0, Math.floor(pts.geometry.drawRange.count * reduction));
306304
pts.geometry.setDrawRange(0, count);
307305
}
308306
}
309-
layer.counters.displayedCount *= reduction;
307+
layer.displayedCount *= reduction;
310308
}
311309

312310
const now = Date.now();

utils/debug/PointCloudDebug.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ export default {
153153
elt.obj.material.visible = layer.dbgDisplayParents;
154154

155155
if (v && !elt.obj.material.visible) {
156-
layer.counters.displayedCount -= elt.obj.geometry.drawRange.count;
156+
layer.displayedCount -= elt.obj.geometry.drawRange.count;
157157
}
158158
}
159159
}

0 commit comments

Comments
 (0)