Fix DFU flash: ensure cleanup callback runs on USB error#2432
Merged
sensei-hacker merged 1 commit intoiNavFlight:masterfrom Nov 27, 2025
Merged
Fix DFU flash: ensure cleanup callback runs on USB error#2432sensei-hacker merged 1 commit intoiNavFlight:masterfrom
sensei-hacker merged 1 commit intoiNavFlight:masterfrom
Conversation
2f534cb to
d4fa1e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Problem
After DFU flashing completes successfully, users cannot reconnect to the flight controller without restarting the configurator.
Root Cause
In
stm32usbdfu.js, when the final USB controlTransfer fails (expected when device reboots after successful flash), the error handler logs the error but doesn't call the callback. This leavesGUI.connect_lock = true, preventing reconnection.Solution
Call the callback with an error code even when USB transfer fails, ensuring
cleanup()runs andGUI.connect_lockgets cleared.Testing
Files Changed
js/protocols/stm32usbdfu.js(+2 lines)PR Type
Enhancement, Bug fix, Tests, Documentation