Merged
Conversation
i-davydenko
force-pushed
the
dev-cli-sessions
branch
from
bccfbfb to
1b9d750
Compare
i-davydenko
force-pushed
the
dev-cli-sessions
branch
from
1b9d750 to
c6f3a8e
Compare
11 tasks
dgsudharsan
suggested changes
Nov 3, 2023
scripts/hostcfgd
Outdated
There was a problem hiding this comment.
Please add more readable error. I believe error in this situation should be "Invalid configuration. Missing POLICIES in SSH_SERVER config"
scripts/hostcfgd
Outdated
There was a problem hiding this comment.
Please add better comments. Why do we need ignore list here? Why are we not processing when max_sessions in key?
Owner
Author
There was a problem hiding this comment.
max_session config applied via already existing limits.j2 config file, that handled by PamLimitsCfg class
i-davydenko
force-pushed
the
dev-cli-sessions
branch
3 times, most recently
from
d8972a1 to
f4db573
Compare
dgsudharsan
approved these changes
Nov 23, 2023
update hostcfgd: add serial-console and extend ssh-server modules, update existing tests, introduce serial-console test
i-davydenko
force-pushed
the
dev-cli-sessions
branch
from
f4db573 to
b035aad
Compare
This was referenced Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for cli-sessions feature
HLD: sonic-net/SONiC#1367