fix(aries-connector): upgrade aries to credo#4153
fix(aries-connector): upgrade aries to credo#4153oGranny wants to merge 1 commit intohyperledger-cacti:mainfrom
Conversation
Signed-off-by: oGranny <[email protected]>
|
@oGranny Hello, thanks for your contribution. I haven't found any information on the new credo packages being incompatible with the CommonJS-based TypeScript. Also, I didn't find out about that Jest incompatibility. Could you provide references to that information? |
|
Hello @LordKubaya, Jest is currently CJS-oriented, while the Credo packages are ESM-first (.mjs entrypoints, credo-ts/askar, credo-ts/core, credo-ts/didcomm). In that context, Jest tries to execute ESM from node_modules as CJS and fails (shown below) output when i run the tests:credo-ts/askar, credo-ts/core and credo-ts/didcomm exports only build/index.mjs. Jest docs ESM support is still experimental and requires ESM-aware config, including running Node with --experimental-vm-modules https://jestjs.io/docs/ecmascript-modules |
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.
Fixes #4090
During validation, I observed that the newer Credo packages are built for a NodeNext/ESM environment and are not compatible with the repository’s current CommonJS-based TypeScript and Jest configuration.
@LordKubaya, @RafaelAPB Could you please advise on the preferred next step?