Skip to content

Bump msrv to 1.60#3250

Closed
Ruben2424 wants to merge 4 commits intohyperium:masterfrom
Ruben2424:bump-msrv
Closed

Bump msrv to 1.60#3250
Ruben2424 wants to merge 4 commits intohyperium:masterfrom
Ruben2424:bump-msrv

Conversation

@Ruben2424
Copy link
Copy Markdown
Contributor

CI fails in #3184 because the log crate now requires rustc version 1.60.

@seanmonstar
Copy link
Copy Markdown
Member

Do we need to bump it? Is log a dependency? Or just a dev-dependency?

@Ruben2424
Copy link
Copy Markdown
Contributor Author

i just ran cargo tree it is under the normal dependency tree under want and mio.

@seanmonstar
Copy link
Copy Markdown
Member

If we upgrade to want 0.3.1, it no longer depends on log. And by removing the default-features from mio, we'll be free!

This reverts commit 841439c.
This reverts commit beb7659.
@Ruben2424
Copy link
Copy Markdown
Contributor Author

Ruben2424 commented Jun 15, 2023

It looks like want 0.3.1 fixes the issue. No change needed.
Can you re-run CI in #3184

@Ruben2424 Ruben2424 closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants