feat: make body::Sender and Body::channel private#2970
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Aug 29, 2022
Merged
feat: make body::Sender and Body::channel private#2970seanmonstar merged 1 commit intohyperium:masterfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
- update tests to work without these types
seanmonstar
approved these changes
Aug 29, 2022
cratelyn
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Jan 24, 2025
see linkerd/linkerd2#8733. `Body::channel()` is no longer exposed in hyper's 1.0 release. this commit adds `#[allow(deprecated)]` attributes. an upstream patch will mark this as deprecated. * linkerd/linkerd2#8733 * hyperium/hyper#2962 * hyperium/hyper#2970 Signed-off-by: katelyn martin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
body::SenderandBody::channel(currently namedRecv::channel) private, and update the tests that relied on these types. As far as I can see there were only two affected tests, as well as theend_to_endbenchmark which is currently disabled (#2930).I ended up using
#[allow(unused)]a few places inbodyafter making the aforementioned types private, please let me know if you'd like me to take a different approach.This closes #2962