Skip to content

feat(lib): Move from log to tracing in a backwards-compatible way #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmonstar merged 7 commits into from
Jul 7, 2020
Merged

feat(lib): Move from log to tracing in a backwards-compatible way #2204

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c402eb7
feat(lib): Move from `log` to `tracing` in a backwards-compatible way
May 16, 2020
01a8cff
how? do? cargo? features? work?
May 16, 2020
dd99479
Add `log` feature to `tracing` to not break existing users
davidbarsky Jul 7, 2020
0c1b134
i don't really understand how cargo features work
davidbarsky Jul 7, 2020
f64b768
address review comments
davidbarsky Jul 7, 2020
aedf5bb
address eliza's comment
davidbarsky Jul 7, 2020
ae1b445
phew, maybe one more time?
davidbarsky Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ http-body = "0.3.1"
httparse = "1.0"
h2 = "0.2.2"
itoa = "0.4.1"
tracing = { version = "0.1", default-features = false, features = ["std", "log"] }
tracing = { version = "0.1", features = ["log"] }
pin-project = "0.4"
time = "0.1"
tower-service = "0.3"
Expand Down Expand Up @@ -73,7 +73,6 @@ tcp = [
]
log = [
"tracing/log",
"tracing/std"
]

# `impl Stream` for things
Expand Down