-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
http2::handshake() is useless in 1.0 given no default executor #3128
Copy link
Copy link
Closed
Labels
B-breaking-changeBlocked: this is an "API breaking change".Blocked: this is an "API breaking change".C-bugCategory: bug. Something is wrong. This is bad!Category: bug. Something is wrong. This is bad!
Milestone
Description
Version
hyper 1.0.0-rc2
Description
hyper::client::conn::http2::handshake(io).await causes an instant panic. Internally it performs Builder::new().handshake(io).await which uses the Exec::Default executor. There is no longer a default tokio runtime implied since the removal of the runtime feature.
https://github.com/hyperium/hyper/blob/master/src/common/exec.rs#L36-L38
There is a TODO in this file to refactor executors. But I couldn't find a relevant issue, so I wanted to open one to ensure this doesn't get included in the official release
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
B-breaking-changeBlocked: this is an "API breaking change".Blocked: this is an "API breaking change".C-bugCategory: bug. Something is wrong. This is bad!Category: bug. Something is wrong. This is bad!