New send flow control #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Aug 18, 2017
Collaborator
olix0r
left a comment
olix0r
left a comment
There was a problem hiding this comment.
the high-level api seems sufficient to me. once we can release capacity, we'll be able to add some RAII'd helper on top of this, which will be cool.
src/proto/streams/flow_control.rs
Outdated
| /// must ensure that the window has capacity. | ||
| pub fn send_data(&mut self, sz: WindowSize) { | ||
| assert!(sz <= self.window_size as WindowSize); | ||
| self.window_size -= sz as i32; |
Collaborator
There was a problem hiding this comment.
as noted in chat, we'll also need to account for what happens when the initial window size is decreased.
| return Ok(()); | ||
| } else if capacity < stream.requested_send_capacity { | ||
| // TODO: release capacity | ||
| unimplemented!(); |
Collaborator
Author
|
Ok, I restructured the send flow control such that data writes are always accepted. This will make it easier to accept SETTINGS frames that decrease the window. |
cxw620
pushed a commit
to hanyu-dev/miku-h2
that referenced
this pull request
Jan 20, 2025
…erium#25) This helps finding the root cause of why the assertion in FlowControl::dec_send_window failed in the first place. See hyperium#692 for more details. Co-authored-by: Anthony Ramine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress