Fix concurrent mDNS resolution by verifying requested hostname #1940
+68
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- libsrc/mdns/MdnsBrowser.cpp:119-170 now keeps each resolver self-contained: the resolver’s resolved signal is handled locally (no shared isAddressResolved signal), link‑local results are ignored on the spot, and the completion signal now carries the hostname so concurrent lookups can’t bleed into one another. - include/mdns/MdnsBrowser.h:62-112 reflects the slimmer API—removed the unused slot/signal and updated isFirstAddressResolved to emit both hostname and address. - include/utils/NetUtils.h:109-146 listens for the hostname-tagged completion and ignores unrelated emissions, so every resolveMDnsHostToAddress call exits only when its own hostname was resolved. Courtesy of OpenAI Codex ;) This fixes hyperion-project#1906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Courtesy of OpenAI Codex ;)
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: