This repository was archived by the owner on Feb 8, 2021. It is now read-only.
Merge containerd-nslistener and runv-shim #523
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a conflict for current architecture, currently for each
container, we have four processes: runv-shim, runv-containerd,
ns-listener and qemu-system-x86. We show pid of runv-shim as runv
container's pid so that the runv-shim can proxy the exit code, signal
and winsize change, but we also need to show pid of nslistener as runv
container's pid so that it can listen on network change so that the CNI
network plugin can work.
Also the future POD support also need one single shim/ns-listener
process pid to identify the container, two processes makes everything a
chaos.
All these things lead to one result: runv-shim and nslistener must belong
to a single process. That's exactly what this commit is doing.
Enjoy it!
Signed-off-by: Zhang Wei [email protected]