refactor: Extract helper functions from processAlert

[pulpdrew]

This PR extracts a couple of functions out of the excessively long processAlert function, to improve readability.

This is also intended to simplify HDX-2568, which will be able to re-use some of these functions.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c81b612

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
hyperdx-v2-oss-app	Ready	Preview	Comment	Nov 7, 2025 7:06pm

[claude]

✅ No critical issues found.

This is a clean refactoring that improves readability by extracting logical chunks from the overly long processAlert function. The extracted helper functions are well-named, properly typed, and maintain the original logic flow.

Minor observations (non-blocking):

• Good use of JSDoc comments for the extracted functions
• Logic preservation appears correct throughout
• Error handling properly maintained in trySendNotification
• Type safety maintained with proper use of TypeScript and return types

The refactoring will make HDX-2568 implementation cleaner by allowing reuse of these functions.

[github-actions]

E2E Test Results

✅ All tests passed • 39 passed • 3 skipped • 291s

Status	Count
✅ Passed	39
❌ Failed	0
⚠️ Flaky	0
⏭️ Skipped	3

View full report →