refactor: Rename error instrumentation fn name for filtering out #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1f2320 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestii
commented
Jun 14, 2024
| } | ||
|
|
||
| public report( | ||
| protected hdxReport( |
Contributor
Author
There was a problem hiding this comment.
why was this public? InstrumentationBase doesn't define a report method 🤔
Member
There was a problem hiding this comment.
not sure, very weird. nothing from the instrumentation should be public
Member
There was a problem hiding this comment.
its used in otel-web (
hyperdx-js/packages/otel-web/src/index.ts
Line 726 in 105caf7
ernestii
force-pushed
the
fix-sdk-frame-filtering
branch
from
9ee330c to
8b80eab
Compare
wrn14897
approved these changes
Jun 17, 2024
wrn14897
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.