remove plugins_url() for twitter since already a URL and use proper deps arg for wp_enqueue_script #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eps arg Don't know if you want a specific version of the twitter widgets.js. So, the version could possibly be blank or set to something other than 1.0.0.
This was referenced Oct 13, 2023
Member
|
Yes. This looks fine. |
Member
|
@composerjk In the end I removed the inclusion of the external widget js as it was being concatenated to the base URL, so not loading and besides it doesn't appear to be required for sharing. See #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if you want a specific version of the twitter widgets.js. So, the version could possibly be blank or set to something other than 1.0.0.