Fix crashers found via fuzzing #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 19, 2015 14:09
Added a guarding defer to catch panics in protocol 0 and 1 - Protocol 0 guard added to opcode_DICT and opcode_SETITEM - Protocol 1 guard added to opcode_SETITEMS
|
Hi, It can make sense to extend the Fuzz function to Unpickle, Pickle and then Unpickle again. You can also check that Pickle and second Unpickle do not fail, and also that results of Unpickle's are equal. See for example: |
|
I'll review these soon. |
|
Any word on when this might get merged? Code changes are pretty simple and definitely guard against reproducible panics... |
hydrogen18
added a commit
that referenced
this pull request
Nov 2, 2015
Fix crashers found via fuzzing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.