Fixes build failure on modern NDKs (r23+). #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define `USE_FILE32API` to force a fallback from the missing `ftello()`/`fseeko()` to the standard `ftell()`/`fseek()`, resolving the compile error. This may limit support for files > 2GB on 32-bit systems.
NeroBurner
suggested changes
Sep 18, 2025
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
I also don't like trailing spaces, but this is an unrelated change. Please remove from PR (can also be done when you move the PR to cpp-pm fork)
|
|
||
|
|
||
| # Set a consistent MACOSX_RPATH default across all CMake versions. | ||
| # Set a consistent MACOSX_RPATH default across all CMake versions. |
There was a problem hiding this comment.
I also don't like trailing spaces, but this is an unrelated change. Please remove from PR
| option(USE_AES "enables building of aes library" ON) | ||
| if(USE_AES) | ||
| set(AES_SRC | ||
| set(AES_SRC |
There was a problem hiding this comment.
I also don't like trailing spaces, but this is an unrelated change. Please remove from PR
| aes/sha1.c) | ||
|
|
||
| set(AES_PUBLIC_HEADERS | ||
| set(AES_PUBLIC_HEADERS |
There was a problem hiding this comment.
I also don't like trailing spaces, but this is an unrelated change. Please remove from PR
Author
Just moved to cpp-pm#1 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
USE_FILE32APIto force a fallback from the missingftello()/fseeko()to the standardftell()/fseek(), resolving the compile error. This may limit support for files > 2GB on 32-bit systems.