Support completion bootstrap for VLM in GRPO/RLOO #4452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
requested changes
Nov 5, 2025
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
I think you mixed 2 contributions in this PR:
- Fix bug in GRPOTrainer
- Add experimental RTPO
I would suggest you split your contributions in 2 PRs, and keep here only the bug fix.
Co-authored-by: Albert Villanova del Moral <[email protected]>
Co-authored-by: Albert Villanova del Moral <[email protected]>
Contributor
Author
|
Thank you for your suggestion |
Contributor
Author
The problem is I don't know how to split it into 2 PR2 properly. |
qgallouedec
reviewed
Nov 6, 2025
qgallouedec
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Nov 6, 2025
Contributor
Author
|
Thank you guys! @qgallouedec @albertvillanova |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fix a little bug in GRPOTrainer.
When inputs are conversational, bootstrap is a list not str, causing a str concat error.
I add a bootstrap type check to fix the bug while maintain the original program