-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update max_length explanation for VLM in online trainers
#4220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I guess the rendering is OK, because the PR docs link does not work: https://moon-ci-docs.huggingface.co/docs/trl/pr_4220/en/index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_length isn't a valid arg of GRPOConfig. It's max_prompt_length
max_length explanation for VLM trainersmax_length explanation for VLM in online trainers
What does this PR do?
For GRPO and RLOO, it currently suggests setting
max_prompt_lengthtoNonewhich is wrong. The correct parameter would bemax_length. Tip copied from SFT trainer.Before submitting
Pull Request section?
to it if that's the case.
Who can review?