ALBERT Tokenizer integration test#9943
Merged
Merged
Conversation
|
|
||
| expected_encoding = { | ||
| "input_ids": [2, 2953, 45, 21, 13, 10601, 11502, 26, 1119, 8, 8542, 3762, 69, 2477, 16, 816, 18667, 3], | ||
| "token_type_ids": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], |
Contributor
There was a problem hiding this comment.
Maybe make a batched integration test to make it a bit more aggressive and make sure atteniton_mask is correctly created?
Member
Author
|
Good point! |
| "The first one is a factorized embedding parameterization. By decomposing the large vocabulary embedding matrix into two small matrices, we separate the size of the hidden layers from the size of vocabulary embedding." | ||
| ] | ||
|
|
||
| encoding = tokenizer(sequences, padding=True) |
Contributor
There was a problem hiding this comment.
(nit & question) what is the recommendeded way of handling padding? Isn't it rather padding="longest"?
Member
Author
There was a problem hiding this comment.
True is longest, False is do_not_pad, and then there's max_length. Either of those 5 work, and they're all mentioned in the docs so I would argue they're all recommended.
patrickvonplaten
approved these changes
Feb 2, 2021
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Great, thanks for adding the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements an integration test for the ALBERT tokenizer.